Jenkins Builds

wondering if we need to keep wakuv1. since we are refactoring anyways, why not remove it and just have waku and use it directly. i am sure a lot of unused code will get deleted as well this way. also wakuv1 is removed from underlying waku repo anyways already.

but @richard-ramos will have better idea than me on this topic though

This would be the next step, but it is not trivial because nearly all protocol tests depend on wakuv1.

wondering if we need to keep wakuv1. since we are refactoring anyways, why not remove it and just have waku and use it directly. i am sure a lot of unused code will get deleted as well this way.
also wakuv1 is removed from underlying waku repo anyways already.

Ideally we'd remove it, yes. The annoying part is that some tests depend on a storenode that's created on the fly, so that means that some tests would need to be modified to use a nwaku node via docker.

Codecov Report

Attention: Patch coverage is 43.90244% with 184 lines in your changes missing coverage. Please review.

Project coverage is 61.79%. Comparing base (3e0b1b2) to head (c22db18).
Report is 31 commits behind head on develop.

❌ Your patch status has failed because the patch coverage (43.90%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

@@             Coverage Diff             @@
##           develop    #6273      +/-   ##
===========================================
- Coverage    61.92%   61.79%   -0.14%     
===========================================
  Files          843      840       -3     
  Lines       111286   111156     -130     
===========================================
- Hits         68918    68685     -233     
- Misses       34388    34499     +111     
+ Partials      7980     7972       -8